[4.3] Moved request validation logic out of crossbar users modules and into kazoo documents users so validation logic can be used by other parts of the code base. #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cant get |
jamesaimonetti
changed the title
… kazoo documents users so validation logic can be used by other parts of the code base.
- the bug allows the doc to be saved even if there are errors - it also causes there to be 2 saves per crossbar save
bradfordben
force-pushed
the
2600-4.3-pr-user-validation
branch
from
5da8408
to
b9a44c4
Compare
response and add the ability to pass the system_error massage in the response
bradfordben
force-pushed
the
2600-4.3-pr-user-validation
branch
from
e2bddc2
to
a091557
Compare
|
@jamesaimonetti When you can, can you please review this, its the same as master commit you approved a few weeks back just with some minor adjustments to suit 4.3 function calls etc It also includes 1 last commit to add an extra return type to the system_error return. This just allows you to pass the message back as part of the error. Its not needed in this case but will be needed for callflows. I have added it as a separate PR's to kazoo5 as-well. |
jamesaimonetti
pushed a commit
that referenced
this pull request
Jun 9, 2020
Moved request validation logic out of crossbar users modules and into kazoo documents users so validation logic can be used by other parts of the code base. PISTON-1078: do not automatically update accounts doc when validated - the bug allows the doc to be saved even if there are errors - it also causes there to be 2 saves per crossbar save Define a common type for the kazoo document validation response and add the ability to pass the system_error massage in the response
|
Merged |
|
@jamesaimonetti Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of previous commit to master.